-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to Methodology page to the header #6332
Conversation
PR Analysis
PR Feedback💡 General suggestions: The PR is well-structured and includes a detailed description of the changes. It would be beneficial to include some automated tests to ensure the new link and the updated styling work as expected across different devices and screen sizes. 🤖 Code feedback:
✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Have you given any thought on how we could potentially add this to mobile as well?
PS: The cypress e2e is really flaky, I had to rerun it 3 times.
Nope, but I think we'll be doing some larger design changes to the mobile version in the near future as Alex has started working on some cool ideas :) |
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
Issue
We are frequently seeing discussions using the map as source, but with people questioning how data is calculated. The FAQ covers part of it, but maybe we can educate more people by also adding a link to the header menu for the Methodology page :)
Description
Adds a link to https://www.electricitymaps.com/methodology, and updates styling to handle the wider menu on smaller devices.
Preview
Three different styling schemes are now in use depending on breakpoint:
On mobile, there is still no header
On devices between mobile and 768px, we now show the menu beneath the logo. Previously we would show the logo, but no menu at all 🤔
![Screenshot 2024-01-11 at 09 44 48](https://private-user-images.githubusercontent.com/3296643/295849832-76a16716-5582-4efa-942e-2d832e0b6c41.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwMjg5MzQsIm5iZiI6MTcxOTAyODYzNCwicGF0aCI6Ii8zMjk2NjQzLzI5NTg0OTgzMi03NmExNjcxNi01NTgyLTRlZmEtOTQyZS0yZDgzMmUwYjZjNDEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjJUMDM1NzE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjQyMmNiODgzOGVhZGJiNjk2MDUwYjAxOWIwOTdkNzA5YmU5ZjQ3MWFkZWExOTNiMmM0MTQ5YmM0YTkzZmU0ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.cuic5vcAnkT2DCt725IvJ0PWUhzoNI0mrktrLBohKF4)
On devices between tablet and desktop, the text size is slightly smaller:
![Screenshot 2024-01-11 at 09 43 58](https://private-user-images.githubusercontent.com/3296643/295849840-4923a89b-e31d-4cdd-be04-e41b2bdb0cbe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwMjg5MzQsIm5iZiI6MTcxOTAyODYzNCwicGF0aCI6Ii8zMjk2NjQzLzI5NTg0OTg0MC00OTIzYTg5Yi1lMzFkLTRjZGQtYmUwNC1lNDFiMmJkYjBjYmUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjJUMDM1NzE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MWQ2OGRjNTgxODY2NDZhMWJhYTg5ZTY3ZjY3YjU1ZWJjNTAwOWUyYmI4YWI2OTQ1NDc0NjM2MmQzOGU4NjQ4OCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.XX0l3BFisI2gfsl8Zo8YlNjP3jTvYCfHouiubLuvlXA)
And on desktops styling is as before:
![Screenshot 2024-01-11 at 09 44 35](https://private-user-images.githubusercontent.com/3296643/295849838-69a10f52-8c77-459a-aa6c-5ef6365e3bc7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwMjg5MzQsIm5iZiI6MTcxOTAyODYzNCwicGF0aCI6Ii8zMjk2NjQzLzI5NTg0OTgzOC02OWExMGY1Mi04Yzc3LTQ1OWEtYWE2Yy01ZWY2MzY1ZTNiYzcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjJUMDM1NzE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODdmMTBjNjQ2ZTgwYjAyN2U0NWEwMmI2MjIwMTlkODJiZTE0YjVkMTg1NTJlMDk5ZDBjMTExNTUwMDRhMDA4MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.a4GZAR6HFRGETxnGvo-kUfjkUPd123SZUgncbSxjFfs)
Double check
pnpx prettier --write .
andpoetry run format
to format my changes.