chore(react-i18next): change usage of custom useTranslation to react-i18next #6443
Conversation
github-actions
bot
added
the
dependencies
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| setupNodeEvents(on, _config) { | ||
| on('before:browser:launch', (browser, launchOptions) => { | ||
| if (browser.family === 'chromium' && browser.name !== 'electron') { | ||
| launchOptions.preferences.default.intl = { | ||
| accept_languages: 'en-US,en', | ||
| selected_languages: 'en-US,en', | ||
| }; | ||
|
|
||
| return launchOptions; | ||
| } | ||
| }); | ||
| }, |
There was a problem hiding this comment.
This is just so the local setup uses the same as the CI everywhere. Was quite annoying when it picked Swedish instead of English all the time.
| @@ -15,7 +14,6 @@ export default function MapOptionSelector({ | |||
| children, | |||
| isMobile, | |||
| }: MapOptionSelectorProps) { | |||
| const { __ } = useTranslation(); | |||
There was a problem hiding this comment.
since we consider any variable that begins with _ to be a placeholder/allowed unused we didn't catch these unused hooks before.
There are a few more that I removed as well.
…-vsprintf-and-use-i18n-interpolation-instead
…-vsprintf-and-use-i18n-interpolation-instead
VIKTORVAV99
requested review from
madsnedergaard,
tonypls and
silkeholmebonnen
|
Sorry for the massive PR guys, should be pretty straight forward to review though. |
| export function getBadgeText(chartData: AreaGraphElement[]) { | ||
| const { __ } = useTranslation(); | ||
|
|
||
| export function getBadgeText(chartData: AreaGraphElement[], t: TFunction) { | ||
| const allEstimated = chartData.every( |
There was a problem hiding this comment.
Nice with this change so we don't need the hook in here :)
VIKTORVAV99
added
the
techdebt
|
@madsnedergaard should we wait for a review from Tony or Silke as well or merge this now? I would like to merge this as soon as possible since it changes 88 files and merge conflicts are only a matter of time... |
…interpolation-instead
I think it's fine to merge it, I reviewed it thoroughly (famous last words 😉) |
VIKTORVAV99
deleted the
vik/ele-3692-remove-vsprintf-and-use-i18n-interpolation-instead
branch
Issue
Description
Updates out translation code to make use of i18n interpolation instead of sprintf-js. This should help with performance, developer experience and bundle size.
Todo:
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.