update return types for capacity_update_configuration #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
VIKTORVAV99
approved these changes
Feb 15, 2024
ghost
pushed a commit
that referenced
this pull request
Feb 16, 2024
* update return types for capacity_update_config * format --------- Co-authored-by: Mathilde Daugy <mathilde.daugy@electricitymaps.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
see #6484 - Our yaml isn't consistent which means it's not loading in correctly to our ModeCapacity class
Description
update_zone_capacity_configandgenerate_zone_capacity_configso that the new capacity format for each mode is a list rather than a dictPreview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.