chore(dependency): Bump date-fns and tree-shake debug logging #6509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
frontend 🎨
dependencies
VIKTORVAV99
requested review from
a team and
silkeholmebonnen
and removed request for
a team
VIKTORVAV99
commented
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
date-fns is outdated and we are adding ~10kb to our bundle for a console log statement.
Description
Updates date-fns that cuts some of the bundle size and tree-shake another ~10kb by wrapping the console logging with a
import.meta.env.DEVclause so it can be tree-shaked in production builds.Preview
Before:
After package bump:
After tree-shaking and package bump:
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.