refactor(parser validation): Remove required mode rule #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parser
python
unitrium
deleted the
robin/pla-632-remove-expected-modes-validation-from-contrib
branch
| @@ -1001,14 +941,6 @@ def validate_production( | |||
|
|
|||
| if validation_criteria: | |||
| return validate(datapoint, logger=logger, **validation_criteria) | |||
|
|
|||
| # NOTE: Why are there sepcial checks for these zones? | |||
| if zone_key.startswith("DK-"): | |||
There was a problem hiding this comment.
Aren't we removing all validation for these zones?
There was a problem hiding this comment.
They don't have any other validation going on so it shouldn't be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The required mode rule has been moved to the quality layer in the back-end therefore there's no need for it in the parser space anymore.
Description
Removing the required mode validation rule from all parsers.
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.