Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CH.py): fix capacity type for downstream insert #6703

Merged
merged 2 commits into from Apr 30, 2024
Merged

fix(CH.py): fix capacity type for downstream insert #6703

merged 2 commits into from Apr 30, 2024

Conversation

pierresegonne
Copy link
Member

Issue

The current implementation casts the capacity value to int64 -> that causes ingestion issues downstream

Description

  • Use instead floats, which seem to be supported

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Apr 29, 2024
VIKTORVAV99
VIKTORVAV99 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh really weird!

Might be worth adding a comment about it :)

@VIKTORVAV99 VIKTORVAV99 mentioned this pull request Apr 29, 2024
Open
2 tasks
@pierresegonne pierresegonne enabled auto-merge (squash) April 30, 2024 07:44
@pierresegonne
Copy link
Member Author

pierresegonne commented Apr 30, 2024 •
edited

We'll be fixing the issue downstream as well, so no need to add a comment in my opinion

@pierresegonne pierresegonne merged commit 59aa770 into master Apr 30, 2024
19 checks passed
@pierresegonne pierresegonne deleted the ps/fix_CH_capacity_types branch April 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIKTORVAV99 VIKTORVAV99 VIKTORVAV99 approved these changes

@FelixDQ FelixDQ Awaiting requested review from FelixDQ

Assignees
No one assigned
Labels
parser python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pierresegonne @VIKTORVAV99