feat(web): Record time slider interactions with plausible #6707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web/src/components/TimeSlider.tsx
Outdated
| onValueChange={(value) => onChange(value[0])} | ||
| onValueChange={(value) => { | ||
| onChange(value[0]); | ||
| trackTimeSliderEvent(value[0]); |
There was a problem hiding this comment.
As far as I can tell value[0] is just a number, e.g. for hourly its 0-24 and monthly 0-12, but how do we know if that number corresponds to hourly, daily, monthly or yearly? Or are we not interested in that?
There was a problem hiding this comment.
Good point, I think we should include the time aggregate too. I'll update the PR to include it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We don't know how users interact with out time slider
Description
This PR sends a custom event to Plausible for interactions with the time slider component, I've alos created a goal and custom property to record the unique interactions with the time slider and property of selected index.