-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): create applied methodologies accordion #6745
Merged
silkeholmebonnen
merged 8 commits into
master
from
silkebonnen/avo-189-create-the-applied-methodologies-accordion
May 27, 2024
Merged
feat(web): create applied methodologies accordion #6745
silkeholmebonnen
merged 8 commits into
master
from
silkebonnen/avo-189-create-the-applied-methodologies-accordion
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silkeholmebonnen
changed the title
feat(web)create the applied methodologies accordion
feat(web): create applied methodologies accordion
May 13, 2024
VIKTORVAV99
reviewed
May 13, 2024
tonypls
reviewed
May 15, 2024
…create-the-applied-methodologies-accordion
VIKTORVAV99
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I took care of the merge conflict (that I caused with another PR) so should be good to go now. Could you please wait with merging this until we have had a chance to deploy the current changes in the update contrib PR though?
…hodologies-accordion
silkeholmebonnen
deleted the
silkebonnen/avo-189-create-the-applied-methodologies-accordion
branch
May 27, 2024 07:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
AVO-189
Description
This PR creates the applied methodologies accordion which links to the methodology page of our website.
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.