Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with graphs on iOS 16 and below #6766

Merged
merged 7 commits into from
May 27, 2024

Conversation

madsnedergaard
Copy link
Member

Issue

Closes #6723

Description

The native Resize Observer implementation does not work on SVG elements in Safari 16 and below.

Preview

Screenshot 2024-05-21 at 10 19 25

@VIKTORVAV99
Copy link
Member

I'll try and test this later, I need to download older iOS versions to emulate 😅

@madsnedergaard
Copy link
Member Author

I'll try and test this later, I need to download older iOS versions to emulate 😅

@tonypls do you have an older Simulator version installed and can test this?
Otherwise I'd mostly worry about testing that it works for current versions as I have tested on iOS 15 :)

Copy link
Collaborator

@tonypls tonypls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on both iOS 15 and 17.

One question, we have the .at polyfil in both the index.html and in the util. Do we want this to init twice?

@VIKTORVAV99
Copy link
Member

LGTM, tested on both iOS 15 and 17.

One question, we have the .at polyfil in both the index.html and in the util. Do we want this to init twice?

We do not...

@madsnedergaard
Copy link
Member Author

LGTM, tested on both iOS 15 and 17.

One question, we have the .at polyfil in both the index.html and in the util. Do we want this to init twice?

Ah great catch, I couldn't understand why we had it in the file but never initiated it 😅

@madsnedergaard madsnedergaard merged commit 809a976 into master May 27, 2024
21 checks passed
@madsnedergaard madsnedergaard deleted the mn/app/fix-resize-observer-bug branch May 27, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The diagrams of 'carbon intensity', 'electricity origin' and 'electricity price' expand infinity to the right.
3 participants