Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electrify fails, looking for btoa #14

Closed
capouch opened this issue Nov 2, 2016 · 6 comments
Closed

electrify fails, looking for btoa #14

capouch opened this issue Nov 2, 2016 · 6 comments
Assignees
Labels

Comments

@capouch
Copy link

capouch commented Nov 2, 2016

I am playing around with electrify, and installed it globally, as per the README.

When I go to run it, it fails looking for module btoa:

Error: Cannot find module 'btoa'

I see btoa in the package.json file in the global node directory, but since btoa is set a as dev dependency it hasn't been installed. install btoa -g doesn't work, nor does installing it as a module for the app I am trying to debug.

Forgive me if I'm missing something obvious.

@ananavati
Copy link
Contributor

@capouch thanks for checking out electrode and electrify module, yes this looks like a bug and we are working on a fix, will publish an update soon.

@capouch
Copy link
Author

capouch commented Nov 2, 2016

Thanks. I moved the btoa into the regular dependencies and it's working just fine. I'll watch for 2.2.1.

FWIW the global install throws this message:
npm WARN bl@0.7.0 requires a peer of stream-browserify@* but none was installed.

@ananavati
Copy link
Contributor

+ electrode-electrify@2.3.0 should fix this bug.

@capouch Can you please verify if v2.3.0 fixes this particular bug close out on this issue.

@capouch
Copy link
Author

capouch commented Nov 2, 2016

Indeed 2.3.0 installs "fine."

There is one other dependency complaint; browserify@3.46.1 -> glob@3.2.11->minimatch@0.3.0:

npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

This is getting pretty far afield from electrify, though, and I didn't report it in the earlier message because it is a pretty common warning I see often.

@ananavati
Copy link
Contributor

ananavati commented Nov 2, 2016

yeah that warning is coming up because of this
screen shot 2016-11-02 at 4 46 34 pm

dependencies have been upgraded in 60f41ad but closing out this ticket since the bug has been fixed.

@capouch
Copy link
Author

capouch commented Nov 2, 2016

@ananavati Yes and thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants