Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade image-picker to latest 5.3.1 for ERN 0.46.x to 0.50.x #248

Merged
merged 1 commit into from
May 11, 2023

Conversation

rthic23
Copy link
Contributor

@rthic23 rthic23 commented May 8, 2023

Upgrade react-native-image-picker to latest 5.3.1 for ERN 0.46.x to 0.50.x - https://github.com/react-native-image-picker/react-native-image-picker

Added Imagepicker plugin support for 3.0.0+ - #246
Tested in sample miniapp for both platforms.

@rthic23 rthic23 force-pushed the upgrade-image-picker-0.50.x branch 2 times, most recently from 93dffc5 to ef8c024 Compare May 10, 2023 18:53
@rthic23 rthic23 requested a review from leekuo May 11, 2023 06:24
Copy link
Member

@leekuo leekuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ERN versions < 0.50 intentionally stay at the older version?

@rthic23
Copy link
Contributor Author

rthic23 commented May 11, 2023

👍

ERN versions < 0.50 intentionally stay at the older version?

not intentional was testing in 0.50 first. Will update it to add from 0.46 to 0.50.

@rthic23 rthic23 force-pushed the upgrade-image-picker-0.50.x branch from ef8c024 to b46a044 Compare May 11, 2023 18:35
@rthic23 rthic23 changed the title Upgrade image-picker to latest 5.3.1 for 0.50.x Upgrade image-picker to latest 5.3.1 for ERN 0.46.x to 0.50.x May 11, 2023
@rthic23 rthic23 force-pushed the upgrade-image-picker-0.50.x branch from b46a044 to 0c4f61f Compare May 11, 2023 18:36
@rthic23 rthic23 merged commit c62a339 into electrode-io:master May 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants