Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter duplicate module name suffix for package name #316

Closed
krunalsshah opened this issue Nov 7, 2017 · 0 comments
Closed

Filter duplicate module name suffix for package name #316

krunalsshah opened this issue Nov 7, 2017 · 0 comments
Assignees
@krunalsshah
Labels
command-improvement good-first-issue
Milestone
0.11.0

Comments

@krunalsshah
Copy link
Contributor

krunalsshah commented Nov 7, 2017 •
edited

Inspiration
Just re-did the Getting Started guide and when I ran ern create-miniapp MovieListMiniApp it propose a package name as : movie-list-mini-app-miniapp

If the module name that the user provide (or modified by prompt) is suffixed by Api, do not add -api suffix for package name to avoid -api-api.

Commands impacted create-miniapp, create-api and create-api-impl
@krunalsshah krunalsshah mentioned this issue Nov 7, 2017
Closed
@belemaire belemaire added this to the v0.11.0 milestone Nov 7, 2017
@krunalsshah krunalsshah self-assigned this Nov 8, 2017
@krunalsshah krunalsshah changed the title Do not add module suffix in name if already present Filter duplicate module name suffix for package name Nov 8, 2017
This was referenced Nov 8, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krunalsshah krunalsshah

Labels
command-improvement good-first-issue
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@belemaire @krunalsshah