Improve xcconfig file update #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public async setBuildSettings(buildSettings: BuildSettings): Promise<BuildSettings> { | ||
| let configFileContent = (await exists(this.filePath)) ? (await readFile(this.filePath)).toString() : '' | ||
| if (configFileContent.length !== 0 && configFileContent[configFileContent.length-1] !== '\n') { | ||
| // Make sure that we have a new line at end of file for proper appending |
belemaire
force-pushed
the
improve-xcconfig-file-update
branch
from
878580f
to
433972f
Compare
This was referenced Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the logic for updating build settings in an existing xcconfig file.
Current logic is fully overwriting the file with up to date build settings, only keeping the build settings but trashing any other content that was in the file.
For example, if the file content was
And we were to update
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIEStoNO, then current logic would just overwrite the existing file with justLosing the comment header (which is not a huge deal), but also losing the
#includestatement (much more problematic).This PR updates the logic to add/update build settings in an xcconfig file, so that only surgical patching is done to the file, to solely update what's needed, keeping the rest intact.