This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Make new require.extensions values still writeable #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2015
anaisbetts
added a commit
that referenced
this pull request
Oct 23, 2015
Make new require.extensions values still writeable
|
Thanks @maxkorp! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having these not be writeable causes errors in test land between electron-compile and some utilities like proxyquire and istanbul, since they attempt to temporarily overwrite those values. This makes it so they can be rewritten as necessary. Such that electron-compile won't have to be the only module allowed to load stuff or be forced to be the last loader registered