Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Task creates Atom.app, should it be Electron.app? #30

Closed
martinchooooooo opened this issue Apr 23, 2015 · 2 comments
Closed

Task creates Atom.app, should it be Electron.app? #30

martinchooooooo opened this issue Apr 23, 2015 · 2 comments

Comments

@martinchooooooo
Copy link

I'm trying to migrate the build scripts for LightTable which is broken since the name change to Electron. In trying to be consistent and remove the mention of Atom everywhere, I notice that this task creates an Atom.app package. I was expecting an Electron.app directory...

I tried recreating this in a new project buy following the same steps LightTable does, and I get ./electron/Atom.app

Gruntfile.js

module.exports = function(grunt) {

  // Project configuration.
  grunt.initConfig({
    pkg: grunt.file.readJSON('package.json'),
    "download-electron": {
      version: "0.22.1",
      outputDir: "./electron",
      rebuild: true
    }
  });

  grunt.loadNpmTasks('grunt-download-electron');

};

package.json

{
    "name": "martin",
        "version": "0.1.0",
        "devDependencies": {
            "grunt": "^0.4.5",
            "grunt-download-electron": "^2.0.0"
        }
}

Then I run

> npm install grunt-cli
> npm install
> ./node_modules/.bin/grunt download-electron

I'm running on
OSX 10.9,5

martinchooooooo added a commit to martinchooooooo/LightTable that referenced this issue Apr 23, 2015
It seems though that the download-electron grunt task seems to create an
Atom.app package. Was expecting it to be Electron.app and raised an issue
for them here electron-archive/grunt-download-electron#30

NOTE: I haven't tested this on Linux or Windows
@simtel12
Copy link
Contributor

This is because the older releases of electron are still all named Atom. They would all have to be rebuilt in order to rename them, so I suspect they're just going to leave the older releases as atom, and newer ones will be electron.

In order to see Electron.app, upgrade the version that you're downloading to 0.24.0

@martinchooooooo
Copy link
Author

Ahh perfect, makes sense.

Cheers for the explanation :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants