packaging variables

[mmahalwy]

I see we have checks for node_env to be development or not, but process envs don't get packaged in (for example, I packaged with production NODE_ENV). Thoughts about this?

[chentsulin]

That's why we only check process.env.process === 'development' for now. If eventually we have to check something like: process.env.process === 'production', we have to add some scripts into our build step.

It seems that you already find some good enough suggestions:

• Set process.env variables when opening packaged app electron/electron#4415
• Package with process.env variables set electron/packager#259

[chentsulin]

The easiest solution I can find is that set default NODE_ENV to production at first line of main.js

process.env.NODE_ENV = process.env.NODE_ENV || 'production';

@mmahalwy What do you think?