Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .less support #62

Closed
3 tasks done
catalinmiron opened this issue Oct 19, 2015 · 4 comments
Closed
3 tasks done

Add .less support #62

catalinmiron opened this issue Oct 19, 2015 · 4 comments

Comments

@catalinmiron
Copy link
Contributor

Need

As a developer
I want to use css preprocessors
So that I'll increase my productivity and DX[Developer Experience]

Solution

  • add less-loader as dev dependencies
  • in webpack.config.development.js
{
  test: /\.less$/,
  loader: ['style-loader!css-loader!less-loader']
}
  • in webpack.config.production.js
{ 
  test: /\.less$/,
  loader: ExtractTextPlugin.extract('style-loader','css-loader!less-loader')
}
catalinmiron added a commit to catalinmiron/electron-react-boilerplate that referenced this issue Oct 19, 2015
catalinmiron added a commit to catalinmiron/electron-react-boilerplate that referenced this issue Oct 19, 2015
catalinmiron added a commit to catalinmiron/electron-react-boilerplate that referenced this issue Oct 19, 2015
We'll export into one single file called style.css, because there's no need to initialize twice the plugin.
catalinmiron added a commit to catalinmiron/electron-react-boilerplate that referenced this issue Oct 19, 2015
@chentsulin
Copy link
Member

Thanks for high quality PR here 👍 , but I doubt we should support less in this boilerplate.

See also #50, now I want to keep webpack config just simple:

I ever use sass, scss, less, stylus before and now postcss. We should not support all of those in one boilerplate and should let user make a decision themselves.

@catalinmiron
Copy link
Contributor Author

@chentsulin fair enough 👍

What do you think about ExtractTextPlugin initialization, this commit, can we merge it, without less of course, or it's out of scope?

Thanks for high quality PR here 👍

It's not a problem, since this repo is a bless :godmode: 🍰

@chentsulin
Copy link
Member

Sure, maybe open a new PR or rebase to modify on that commit, after that i will merge or cherry-pick it.

@catalinmiron
Copy link
Contributor Author

Closing this in favour of #64 (PR: #65)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants