Use module property from dev webpack config in DLL webpack config #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update webpack.config.renderer.dev.dll.js * update webpack to support sass files * update webpack to support sass files
Fixes electron-react-boilerplate#1468 To avoid a circular dependency, this relies on a check against the parent module's filename for `webpack.config.renderer.dev.dll.js`. It's expected that developers who rename config files will hopefully grep the codebase for this filename before changing it. This change also includes this check again when configuring `DllReferencePlugin`, because it is no longer guaranteed that the DLL manifest file exists by the time the renderer config specifies plugins. I played around with the idea of creating a `webpack-merge` strategy that plucks the value of `module` from the dev webpack config, but it wouldn't help much because, in `webpack.config.renderer.dev.js`, the `DllReferencePlugin` would still try to require the manifest (which would not exist).
|
I changed the base of this PR to the |
…t-boilerplate into fix/require-module-in-dll
|
Conflicts resolved |
amilajack
requested changes
May 2, 2018
webpack.config.renderer.dev.js
Outdated
| @@ -23,11 +23,13 @@ const port = process.env.PORT || 1212; | |||
| const publicPath = `http://localhost:${port}/dist`; | |||
| const dll = path.resolve(process.cwd(), 'dll'); | |||
| const manifest = path.resolve(dll, 'renderer.json'); | |||
| const requiredByDLLConfig = | |||
| module.parent.filename.indexOf('webpack.config.renderer.dev.dll') !== -1; | |||
There was a problem hiding this comment.
Prefer ES6 semantics instead (.includes())
|
Thanks for this! |
amilajack
added a commit
that referenced
this pull request
May 24, 2018
* Misc code style changes to menu.js * v0.13.3 * More consistent node path * Allowed node_modules to be checked by flow * add prettier to format js files (#1418) * Remove jsdom dep (#1411) * Remove dynamic import dep (#1408) * Add .sass files support (#1412) * Update webpack.config.renderer.dev.dll.js * update webpack to support sass files * update webpack to support sass files * Misc code style changes to menu.js * chore: add perttier husky lint-stage eslint-config-prettier and add scripts * refactor: use prettier to format code * fix: fix lint error and add eslint prettier config * fix: replace registry url from registry.npmjs.org to registry.yarnpkg.com for new add package * docs: update changelog * chore: add format-fix script and make format script just to check which files need to format * format: use prettier to format webpack files * docs: update change log - add format-fix script * feat: add prettier in `lint-fix` script * Removed unnecessary deps * Updated deps * Upgraded to webpack 4 * Run prettier even if eslint fails * createBrowserHistory to createHashHistory for prod (#1184) * Filter deps without entrypoint from dll * Bumped deps * Temporary hack to get flow working with webpack-cli * Use module property from dev webpack config in DLL webpack config (#1497) * Remove jsdom dep (#1411) * Remove dynamic import dep (#1408) * Add .sass files support (#1412) * Update webpack.config.renderer.dev.dll.js * update webpack to support sass files * update webpack to support sass files * Misc code style changes to menu.js * Use module property from dev webpack config in DLL webpack config Fixes #1468 To avoid a circular dependency, this relies on a check against the parent module's filename for `webpack.config.renderer.dev.dll.js`. It's expected that developers who rename config files will hopefully grep the codebase for this filename before changing it. This change also includes this check again when configuring `DllReferencePlugin`, because it is no longer guaranteed that the DLL manifest file exists by the time the renderer config specifies plugins. I played around with the idea of creating a `webpack-merge` strategy that plucks the value of `module` from the dev webpack config, but it wouldn't help much because, in `webpack.config.renderer.dev.js`, the `DllReferencePlugin` would still try to require the manifest (which would not exist). * Use includes() rather than indexOf() * Updated all deps to latest semver * Bumped deps * Bumped all deps to latest semver * Update changelog * Increased delay for e2e counter test * Updated lock file * Bumped ci node versions * Reverted version change in CHANGELOG [ci skip]
vikr01
pushed a commit
to vikr01/electron-react-boilerplate
that referenced
this pull request
Jun 27, 2018
* Misc code style changes to menu.js * v0.13.3 * More consistent node path * Allowed node_modules to be checked by flow * add prettier to format js files (electron-react-boilerplate#1418) * Remove jsdom dep (electron-react-boilerplate#1411) * Remove dynamic import dep (electron-react-boilerplate#1408) * Add .sass files support (electron-react-boilerplate#1412) * Update webpack.config.renderer.dev.dll.js * update webpack to support sass files * update webpack to support sass files * Misc code style changes to menu.js * chore: add perttier husky lint-stage eslint-config-prettier and add scripts * refactor: use prettier to format code * fix: fix lint error and add eslint prettier config * fix: replace registry url from registry.npmjs.org to registry.yarnpkg.com for new add package * docs: update changelog * chore: add format-fix script and make format script just to check which files need to format * format: use prettier to format webpack files * docs: update change log - add format-fix script * feat: add prettier in `lint-fix` script * Removed unnecessary deps * Updated deps * Upgraded to webpack 4 * Run prettier even if eslint fails * createBrowserHistory to createHashHistory for prod (electron-react-boilerplate#1184) * Filter deps without entrypoint from dll * Bumped deps * Temporary hack to get flow working with webpack-cli * Use module property from dev webpack config in DLL webpack config (electron-react-boilerplate#1497) * Remove jsdom dep (electron-react-boilerplate#1411) * Remove dynamic import dep (electron-react-boilerplate#1408) * Add .sass files support (electron-react-boilerplate#1412) * Update webpack.config.renderer.dev.dll.js * update webpack to support sass files * update webpack to support sass files * Misc code style changes to menu.js * Use module property from dev webpack config in DLL webpack config Fixes electron-react-boilerplate#1468 To avoid a circular dependency, this relies on a check against the parent module's filename for `webpack.config.renderer.dev.dll.js`. It's expected that developers who rename config files will hopefully grep the codebase for this filename before changing it. This change also includes this check again when configuring `DllReferencePlugin`, because it is no longer guaranteed that the DLL manifest file exists by the time the renderer config specifies plugins. I played around with the idea of creating a `webpack-merge` strategy that plucks the value of `module` from the dev webpack config, but it wouldn't help much because, in `webpack.config.renderer.dev.js`, the `DllReferencePlugin` would still try to require the manifest (which would not exist). * Use includes() rather than indexOf() * Updated all deps to latest semver * Bumped deps * Bumped all deps to latest semver * Update changelog * Increased delay for e2e counter test * Updated lock file * Bumped ci node versions * Reverted version change in CHANGELOG [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1468
To avoid a circular dependency, this relies on a check against the parent module's filename for
webpack.config.renderer.dev.dll.js. It's expected that developers who rename config files will hopefully grep the codebase for this filename before changing it.This change also includes this check again when configuring
DllReferencePlugin, because it is no longer guaranteed that the DLL manifest file exists by the time the renderer config specifies plugins.I played around with the idea of creating a
webpack-mergestrategy that plucks the value ofmodulefrom the dev webpack config, but it wouldn't help much because, inwebpack.config.renderer.dev.js, theDllReferencePluginwould still try to require the manifest (which would not exist).Lmk if this should be rebased off a different tag.