Set style.global.css rather than style.module.css #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `.global` for global styles. Anything without `.global` will go through css-modules.
epilande
force-pushed
the
css-modules
branch
from
4ae4228
to
3231fb3
Compare
|
LGTM. This one make more sense and encourage people avoid global css. @jhen0409 What do you think? If we want to go this way, we must also update README's css module section. |
|
👍 Great idea! I don't even often write global css, and it's more convenient to name each component. |
|
Updated the README 😃 |
chentsulin
added a commit
that referenced
this pull request
Feb 24, 2016
Set style.global.css rather than style.module.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an idea.
Add
.globalfor global styles.Anything without
.globalwill go through css-modules.Basically reversing the current css implementation.
Projects will most likely have more css modules than global styles. This way we wont have to add
.moduleto all of our css.