Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sass compilation #2540

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Fix sass compilation #2540

merged 2 commits into from
Aug 5, 2020

Conversation

jooohhn
Copy link
Member

@jooohhn jooohhn commented Aug 1, 2020

Fixes #2523

@jooohhn jooohhn requested a review from amilajack August 1, 2020 04:51
Copy link
Member

@amilajack amilajack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jooohhn
Copy link
Member Author

jooohhn commented Aug 1, 2020

Do you know what's causing this? https://github.com/electron-react-boilerplate/electron-react-boilerplate/pull/2540/checks?check_run_id=935900755#step:5:19

@amilajack not sure what's up with the package-ci\nyarn error. It looks like it's been in CI since this commit

@jooohhn jooohhn merged commit fbfb55d into next Aug 5, 2020
@jooohhn jooohhn deleted the fix-sass branch August 5, 2020 02:38
This was referenced Aug 14, 2020
jooohhn added a commit that referenced this pull request Aug 24, 2020
* switch to  @teamsupercell/typings-for-css-modules-loader

* update change log
@jooohhn jooohhn mentioned this pull request Aug 24, 2020
amilajack added a commit that referenced this pull request Sep 26, 2020
* bump deps

* update version to 1.3.0, dedupe yarn.lock

* fix: dedupe lockfile

* dedupe

* update lockfile

* Fix sass compilation (#2540)

* switch to  @teamsupercell/typings-for-css-modules-loader

* update change log

* Possible fix date-fns install timeout bug

* change renovate baseBranch to `next` (#2554)

* Rebase and prep 1.3.1

* Update changelog

* Update patch semver deps

* Bump version to 1.3.1

* Provide default app icon (#2567)

Co-authored-by: Amila Welihinda <amilajack@gmail.com>
Co-authored-by: CZYK <danko@czyk.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants