Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn-support #451

Merged
merged 6 commits into from Oct 22, 2016
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
Expand Up @@ -23,8 +23,8 @@ addons:

install:
- export CXX="g++-4.8"
- npm install -g npm@latest
- npm install
- npm install -g yarnpkg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the alt install methods listed on the docs site https://yarnpkg.com/en/docs/install

It looks like npm i -g yarn is the one we want here.

- yarn
- "/sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen 0 1280x1024x16"

before_script:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -24,12 +24,12 @@ git clone https://github.com/chentsulin/electron-react-boilerplate.git your-proj
```

And then install dependencies.
**ProTip**: Install with [yarn](https://github.com/yarnpkg/yarn) for significantly faster and safer installation

```bash
$ cd your-project-name && npm install
```


## Run

Run these two commands __simultaneously__ in different console tabs.
Expand Down
25 changes: 16 additions & 9 deletions appveyor.yml
@@ -1,25 +1,32 @@
os: unstable
cache:
- node_modules

environment:
matrix:
- nodejs_version: 6
- nodejs_version: 4
install:
- ps: Install-Product node $env:nodejs_version
- set CI=true
- npm install -g npm@latest
- set PATH=%APPDATA%\npm;%PATH%
- npm install

cache:
- node_modules

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add $HOME/.yarn-cache for yarn specific caching

matrix:
fast_finish: true

build: off

version: '{build}'

shallow_clone: true

clone_depth: 1

install:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this line, as npm is still being used in places. I would also add - yarn --version below it.

- ps: Install-Product node $env:nodejs_version
- set CI=true
- npm install -g yarnpkg
- yarn

test_script:
- node --version
- npm --version
- npm run lint
- npm run test
- npm run build
Expand Down