Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Webpack DLL Support #860

Merged
merged 8 commits into from
Mar 31, 2017
Merged

Initial Webpack DLL Support #860

merged 8 commits into from
Mar 31, 2017

Conversation

amilajack
Copy link
Member

@amilajack amilajack commented Mar 29, 2017

  • Enables Webpack DLL for faster Hot Reloading/Reloading

@amilajack amilajack changed the title Initial dll support Initial Webpack DLL support Mar 29, 2017
@amilajack amilajack changed the title Initial Webpack DLL support Initial Webpack DLL Support Mar 29, 2017
.babelrc.js Outdated
@@ -0,0 +1,37 @@
/**
* @HACK: Babel doesn't support using modules as your `babelrc`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just edit .babelrc instead of new file? Like my usage.

Also, we can waiting babel 7 for .babelrc.js support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with this is that node-register doesn't support imports. So none of the npm scripts will work because the import statements won't be transpiled. Use your solution of reading and parsing the .babelrc

@amilajack
Copy link
Member Author

@jhen0409 couldn't get modules: false to work without breaking hot reloading. Lets save that for another PR

@amilajack amilajack merged commit efcf462 into master Mar 31, 2017
@amilajack amilajack deleted the dll-support branch April 1, 2017 02:57
@amilajack amilajack restored the dll-support branch April 2, 2017 19:58
@amilajack amilajack deleted the dll-support branch April 2, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants