Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign prepacked mac build only #1159

Closed
jakubzitny opened this issue Jan 23, 2017 · 6 comments
Closed

Sign prepacked mac build only #1159

jakubzitny opened this issue Jan 23, 2017 · 6 comments

Comments

@jakubzitny
Copy link

  • Version: latest
  • Target: mac, linux, win

I am separating the feature request from #1146 — creating a sign option, that can be used to sign prepacked mac bundle that was already built before, e.g. on a different Linux CI machine.

@jakubzitny
Copy link
Author

Is there any simple way to implement this @develar? It could really help to simplify Mac builds from Linux that are signed on a Mac.

@develar
Copy link
Member

develar commented Mar 13, 2017

It is only one line of code, because now you can build prepackaged app — we don't sign it yet, but should.

What do you build? DMG? Why not just build on Mac?

@jakubzitny
Copy link
Author

jakubzitny commented Mar 13, 2017

Can we create a DMG from prepackaged .app already? We're on electron-builder 12.2, it might not have been there yet, or?

And yeah we have the whole CI pipeline on Linux machines as most of the build tools are more stable and easier to setup and maintain on Linux. We're just scping the Mac zip build to a Mac mini server, sign it there and then we want to continue building DMG where we left off on Linux. Right now we have extra appdmg dependency for this, but running it with electron-builder would be cool.

@develar
Copy link
Member

develar commented Mar 14, 2017

Can we create a DMG from prepackaged .app already

Yes. I realized that it is already supported. Build prepacked app — https://github.com/electron-userland/electron-builder#pack-only-in-a-distributable-format

electron-builder 12.2, it might not have been there yet, or?

No, please use 15.x

@develar develar closed this as completed Mar 14, 2017
@develar
Copy link
Member

develar commented Mar 14, 2017

we want to continue building DMG where we left off on Linux

You cannot because DMG is supported only on mac. So, you just send .app to mac mini and pack it onto dmg (will be signed).

@jakubzitny
Copy link
Author

jakubzitny commented Mar 14, 2017

Right, thanks. The --prepackaged flag for packing is what we'll use. 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants