Skip to content

Do not add "x-amz-acl": "public-read" to the header when uploading artefacts to S3 bucket #1822

Closed
@romanrev

Description

@romanrev
  • Version: 18.3.0
  • Electron-Updater: 2.0.0
  • Target: OSX/Windows

We have to allow the s3:PutObjectAcl in the IAM policy for the electron-builder to be able to successfully upload the artefacts to the S3 bucket, since it always adds a header "x-amz-acl": "public-read" with each upload request - trying to mark every object it uploads to the bucket as publicly readable.
I suggest that this behaviour should be optional - and not the default one, since one can also achieve the same effect with appropriately crafted S3 bucket policy - which we actually prefer to.
Another use case is when an S3 bucket with the built artefacts should not be publicly accessible at all.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions