Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Does electron-builder use electron mas build when packaging for mas & mas-dev? #3392

Closed
rr326 opened this issue Oct 15, 2018 · 4 comments

Comments

@rr326
Copy link

rr326 commented Oct 15, 2018

  • Version: 20.28.4

Not used

  • Target: mas-dev

I am trying to use securityScopedBookmarks as described here and here.

When I do my showOpenDialog callback, I'm getting an empty bookmarks return value, which the documentation says: The bookmarks array will be empty if the app is not bundled for mas

I am bundling for mas. The documentation also says: Note that in order to test this, one must build electron for mas

SO - Is electron-builder bundling for mas with the electron-mas build? (eg: electron-v3.0.4-mas-x64.zip)?

If not, that would explain my problems. If so, then something else is weird.

Thanks.

@rr326
Copy link
Author

rr326 commented Oct 16, 2018

Never mind - I'm pretty certain it does.
(I deleted everything from ~/Library/Caches/electron and confirmed that it is downloading the mas build.)

@rr326 rr326 closed this as completed Oct 16, 2018
@jfuechsl
Copy link

@rr326 I'm running in the same issue you described above. Did you find a fix for it?

@jfuechsl
Copy link

@rr326 Tracked down your comments in electron/electron#11711. I think that will get me somehwere. Thanks for the test repo!

@rr326
Copy link
Author

rr326 commented Feb 20, 2019

Check out this issue.
I think the security scoped bookmark feature is not working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants