Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nsis Updater - Custom Headers Not Sent when Downloading Blockmap #3535

Closed
neilrees opened this issue Dec 10, 2018 · 0 comments
Closed

Nsis Updater - Custom Headers Not Sent when Downloading Blockmap #3535

neilrees opened this issue Dec 10, 2018 · 0 comments

Comments

@neilrees
Copy link
Contributor

neilrees commented Dec 10, 2018

  • Electron-Updater: 4.0.4
  • Target: Windows 10 x64
  • Updater: Nsis

When setting custom headers using autoUpdater.requestHeaders the custom headers are not sent on the request to download the blockmap file.

https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/NsisUpdater.ts#L146 the requestHeaders parameter is not used for the blockmap download.

The downloadUpdateOptions object has a property named requestHeader whereas httpExecutor expects a property named headers.

In our scenario we are setting an Authorization header and are seeing it fall back to doing a full download every time as it is not able to download the blockmap from our update server without providing that header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants