Update loop in windows #359

philipgiuliani · 2016-04-26T06:14:36Z

Hi! I have no idea where i should report it, so i start here with the hope that somebody can help.

I have packaged my windows app with electron builder and i'm using Squirrel.Windows for auto-updates. I've put everything from the release to the FTP and set the URL properly. But now when I start the windows app its in an update loop. It downloads the 1.0.0 every time again.

Does someone has an idea how it happened?

859E5121E95B411FA2107DF3A59E3880D4E9EA0B myapp-1.0.0-ia32-full.nupkg 45302165

Main app index.js (i ommited unreleated code)

if (require("electron-squirrel-startup")) {
    return;
}

app.on('ready', function() {
    // create new browserwindow

    // search for updates
    const updateFeed = os == "darwin" ? "https://HOST/updates/latest" : "https://HOST/releases/win32";

    const autoUpdater = require('auto-updater');
    autoUpdater.on("update-downloaded", function() {
        autoUpdater.quitAndInstall();
    });

    autoUpdater.setFeedURL(updateFeed + '?v=' + app.getVersion());
    autoUpdater.checkForUpdates();
});

I am building the windows distribution with OSX (Vine) with the following command: build --platform win32 --arch ia32

OSX is working fine.

The text was updated successfully, but these errors were encountered:

jbleuzen · 2016-04-26T06:17:10Z

You should show your code that handle auto-update...
Without that, it's pretty hard to help.

philipgiuliani · 2016-04-26T06:24:17Z

Sorry, i was currently editing my post, pressed publish accidently.

develar · 2016-04-26T06:51:20Z

Side note: Don't call autoUpdater.quitAndInstall on "update-downloaded". You should quit only if user click "Ok, quit and install. But better solution is — just show notification — https://github.com/develar/onshape-desktop-shell/blob/master/src/AppUpdater.ts#L24

Please ensure that your updated app has greater version number.

philipgiuliani · 2016-04-26T06:53:19Z

@develar Thanks, yes i've not implemented it correctly yet, just want to get it running first :/ And thanks for the code snippet!

NGINX access.log after installing and starting the application

[26/Apr/2016:08:50:33 +0200] "GET /downloader/releases/win32/RELEASES?v=1.0.0&id=youtv&localVersion=1.0.0&arch=amd64 HTTP/1.1" 200 91
[26/Apr/2016:08:50:49 +0200] "GET /downloader/releases/win32/youtv-downloader-1.0.0-ia32-full.nupkg HTTP/1.1" 200 45302165
[26/Apr/2016:08:50:49 +0200] "GET /downloader/releases/win32/RELEASES?v=1.0.0&id=youtv&localVersion=1.0.0&arch=amd64 HTTP/1.1" 200 91
[26/Apr/2016:08:51:27 +0200] "GET /downloader/releases/win32/youtv-downloader-1.0.0-ia32-full.nupkg HTTP/1.1" 200 19496705

develar · 2016-04-26T07:46:42Z

Please see electron/electron#5057

Do you code sign your app?

philipgiuliani · 2016-04-26T08:26:32Z

Thanks for the link.
No, im not code signing the windows app at the moment. Could it prevent the issue?

develar · 2016-04-26T08:27:23Z

Could it prevent the issue?

No, it can be a reason of issue.

philipgiuliani · 2016-04-26T15:19:09Z

Code signing didn't help.

What's happening:

App starts
Server receives requests to RELEASES and downloads the -full.nupkg two times (auto-updater-win.js downloads updates twice when available. electron/electron#5057)
After download the client restarts (autoUpdater.quitAndInstall())
It starts again from 1

philipgiuliani · 2016-04-26T15:51:54Z

I found the issue. I think its a bug in Squirrel.Windows.

I have always uploaded the ia32 version and not the 64bit version. I installed the 32 bit version on a 64bit PC and got into this loop issue. After uploading the 64bit RELEASES + nupkg it worked fine.

develar · 2016-04-26T16:46:23Z

@philipgiuliani It is your issue due to lack of documentation. Please see #190 (comment) Your update server must serve RELEASES-ia32 as RELEASES on 32-bit update request.

develar · 2016-04-26T16:46:39Z

Reopened — must be documented.

philipgiuliani · 2016-04-26T17:03:14Z

When i generated 32 bit version it generates a RELEASES + RELEASES-ia32. I uploaded both and the content seemed the same. The app fetched the RELEASES file (from logs) and downloaded the app-ia32.nupkg. But looping. So the file was actually present. Thanks for your help.

develar · 2016-04-26T18:00:26Z

The app fetched the RELEASES file

It is an issue in all known update servers. You must send RELEASES-ia32 if RELEASES requested for 32-bit version. See, for example, issue GitbookIO/nuts#32 — nuts server just doesn't support 32-bit releases.

I suggest to distribute only 64-bit versions (forget 32-bit). Or you must fix your update server to support both 32 and 64 bit releases.

But looping.

I see &arch=amd64 in your URL. Are your sure that proper file is returned (i.e. 64-bit version)?

And please, as an easy solution — "I suggest to distribute only 64-bit versions (forget 32-bit)." :)

develar · 2016-04-26T18:34:00Z

I uploaded both and the content seemed the same

If you build only 32-bit, RELEASES file is generated as well and identical to RELEASES-ia32. Yes — it is a bug — we must not generate RELEASES file in this case. I will check.

philipgiuliani · 2016-04-26T19:02:41Z

Yes we're now only distributing 64-bit versions. My update server has currently no logic (just for Squirrel.Mac) because they said Squirrel.Windows doesn't need that. Feel free to close when its fixed :) I'm happy with 64 bit.

develar · 2016-04-27T08:09:47Z

I'm happy with 64 bit.

Good, because real fix is not possible on our side. RELEASES file cannot contain versions for several archs, so, it is update server responsibility to handle this issue. And reality is — no one update server implements it correctly because... damn windows! forget ia32 and use only 64-bit as OS X does for several years.

develar · 2016-04-27T08:11:07Z

On other hand if you distribute only ia32, we should still generate RELEASES file. So, it will be not changed.

philipgiuliani · 2016-04-27T08:20:33Z

It took me about 5 minutes to get OS X updates working... For Windows i spent a day to find out that it is because i only uploaded the x86 version... Yes i think its ok to generate it because its required.

ghost · 2016-05-12T12:46:23Z

I ran into this issue on a project and found a solution. Due to certain restrictions, our application is only available as a 32-bit program, so we had to find a fix for this.

During the build process, electron-builder would output the following files:

app-0.1.0-ia32-full.nupkg
AppSetup-0.1.0-ia32.exe
RELEASES
RELEASES-ia32

Our fix was to:

Delete RELEASES-ia32
Remove all -ia32 strings from the filenames
Update RELEASES with the new filenames

Below is our build script that does this:

builder.build(opts)
    .then(() => {
        const dir = jetpack.cwd('dist', 'win');

        // This is a fix for Squirrel's infinite update loop.
        return dir.removeAsync('RELEASES-ia32')
            .then(() => {
                return Promise.each(dir.listAsync(), (filename) => {
                    if (filename.indexOf('-ia32') !== -1) {
                        const newFilename = filename.replace('-ia32', '');
                        return dir.renameAsync(filename, newFilename);
                    }
                });
            })
            .then(() => {
                return dir.readAsync('RELEASES');
            })
            .then((txt) => {
                txt = txt.replace('-ia32', '');
                return dir.writeAsync('RELEASES', txt);
            });
    })
    .catch((err) => {
        console.log(err);
        process.exit(1);
    });

develar · 2016-05-13T05:46:44Z

@bontibon I will revert #190 (comment) if @mcaoun will confirm that fix doesn't work in any case.

cc @demetris-manikas

So

warn that ia32 for windows is not recommended: "For windows consider only distributing 64-bit"
don't change RELEASES file name and contents.

If @mcaoun will not say that "don't revert, it works for me!", I will publish fix in the 3.x version, not major 4.

develar · 2016-05-13T08:06:51Z

@bontibon Enjoy. 3.22.0 will not modify RELEASES for ia32 anymore.

friksa · 2016-05-18T01:47:41Z

How can you just break all existing build processes? There are many developers depending on these projects. Yes, we would love to live in a perfect world where we do not care about customers that do not upgrade.

develar · 2016-05-18T05:17:03Z

@friksa What do you mean?

friksa · 2016-05-18T11:45:09Z

Our build process was building win32 versions of electron happily. After these changes, it does not.

develar · 2016-05-18T11:47:05Z

@friksa Please specify error, or what's wrong?

friksa · 2016-05-18T12:07:25Z

Got to the bottom of this and it turns out to be easily solvable in the morning. The build process always yielded a folder named "win". Now it is "win-ia32". This caused the build process to break. Adjusting the build process to use the new folder name resolves the issue. Thanks!

develar · 2016-05-18T12:10:26Z

@friksa Sorry for that. Could you please specify why "the build process to break"? Do you publish manually instead of github publisher (or creating issue "support my product_name (amazon s3?) to publish!!!")?

friksa · 2016-05-18T12:13:53Z

We build it with

npm run clean:win && ./node_modules/.bin/build --platform win32 --arch ia32 && node tasks/sign

Then we scp the files to our server and use a home-grown Java server to serve updates.

Since the files were not found in the expected place, the build process reported a broken build.

develar · 2016-05-18T12:16:48Z

node tasks/sign

BTW, code sign is supported (and it is not possible for you to sign correctly outside of build process).

@friksa Thanks for explanation.

Vj3k0 · 2016-05-20T14:02:03Z

I wrote a blog post about building and deploying app, and it supports both 32 and 64 versions of Win:
http://electron.rocks/building-and-deploying-application/

Hope it helps, best,
Vjeko

develar · 2016-05-20T15:01:47Z

@Vj3k0 Thanks a lot for your articles. Please see and comment if possible #413

ccnokes · 2016-06-03T19:19:11Z

@develar for future reference, in what version was this issue introduced and in what issue is it fixed (or has it even been fixed)? Thanks!

develar · 2016-06-04T07:26:10Z

@ccnokes It not our bug, it is Squirrel.windows&nuget design mistake and as unpreventable result — user configuration error. There is no fix — we just revert our feature, because we don't want to fix broken windows. Please see #439

AdrienFery · 2016-09-29T01:09:06Z

Hi,

I have both a 32-bit and 64-bit release of my app and the auto-updater work well with both arch.

When the app starts, I make a request on my server with the following parameters: current app version, platform, arch to check if an update is available. If the current version is already up to date nothing happened... otherwise I call autoUpdater.setFeedURL(feedUrl); with the feedUrl returned by the server (that depends of the version, platform and arch).

weiway · 2016-11-21T23:32:11Z

I think I just met the same looping issue, I reported details to electron project and here is the link.
electron/electron#8040

develar · 2016-11-22T08:05:24Z

Squirrel.Windows is deprecated by electron-builder — consider to use nsis target.

dougludlow · 2016-11-29T16:27:00Z

@develar can you still use the electron autoupdater api with nsis? I thought it relied on squirrel.windows.

dougludlow · 2016-11-29T16:32:32Z

Nevermind, I see #529 now.

Neustradamus · 2020-11-17T00:00:07Z

This bug has been solved in Squirrel?

philipgiuliani closed this as completed Apr 26, 2016

develar reopened this Apr 26, 2016

develar closed this as completed Apr 27, 2016

develar reopened this Apr 27, 2016

develar added windows readme improvement labels Apr 27, 2016

develar closed this as completed in fd7201e Apr 28, 2016

This was referenced May 5, 2016

Squirrel.Windows doesn't escape " in the description #378

Closed

auto-updater not working on windows ia32 #391

Closed

develar mentioned this issue May 13, 2016

Releases file for Windows not uploaded to Github #190

Closed

develar mentioned this issue May 25, 2016

Different names for ia32 and win64 nupkg #439

Closed

ccnokes mentioned this issue Jun 3, 2016

Question: Why does my app always say there's an update? electron/windows-installer#101

Closed

This was referenced Jul 1, 2016

Unable to build windows installer and getting Error: spawn mono ENOENT electron/windows-installer#112

Closed

Unable to build windows installer and getting Error: spawn mono ENOENT #557

Closed

jwheare mentioned this issue Jul 2, 2016

32-bit Windows is not supported irccloud/irccloud-desktop#36

Closed

zh99998 mentioned this issue Sep 2, 2016

document for both 32-bit and 64-bit windows release #720

Closed

Update loop in windows #359

Update loop in windows #359

Comments

philipgiuliani commented Apr 26, 2016 • edited Loading

OSX is working fine.

jbleuzen commented Apr 26, 2016

philipgiuliani commented Apr 26, 2016 • edited Loading

develar commented Apr 26, 2016 • edited Loading

philipgiuliani commented Apr 26, 2016

NGINX access.log after installing and starting the application

develar commented Apr 26, 2016

philipgiuliani commented Apr 26, 2016

develar commented Apr 26, 2016

philipgiuliani commented Apr 26, 2016

philipgiuliani commented Apr 26, 2016

develar commented Apr 26, 2016

develar commented Apr 26, 2016

philipgiuliani commented Apr 26, 2016 • edited Loading

develar commented Apr 26, 2016

develar commented Apr 26, 2016

philipgiuliani commented Apr 26, 2016

develar commented Apr 27, 2016

develar commented Apr 27, 2016 • edited Loading

philipgiuliani commented Apr 27, 2016

ghost commented May 12, 2016

develar commented May 13, 2016

develar commented May 13, 2016

friksa commented May 18, 2016

develar commented May 18, 2016

friksa commented May 18, 2016

develar commented May 18, 2016

friksa commented May 18, 2016

develar commented May 18, 2016 • edited Loading

friksa commented May 18, 2016

develar commented May 18, 2016

Vj3k0 commented May 20, 2016

develar commented May 20, 2016

ccnokes commented Jun 3, 2016

develar commented Jun 4, 2016

AdrienFery commented Sep 29, 2016

weiway commented Nov 21, 2016

develar commented Nov 22, 2016

dougludlow commented Nov 29, 2016

dougludlow commented Nov 29, 2016

Neustradamus commented Nov 17, 2020

philipgiuliani commented Apr 26, 2016 •

edited

Loading

philipgiuliani commented Apr 26, 2016 •

edited

Loading

develar commented Apr 26, 2016 •

edited

Loading

philipgiuliani commented Apr 26, 2016 •

edited

Loading

develar commented Apr 27, 2016 •

edited

Loading

develar commented May 18, 2016 •

edited

Loading