Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command failed winCodeSign makepri.exe (since 20.33.1) #3654

Closed
mirka opened this issue Jan 31, 2019 · 2 comments
Closed

Command failed winCodeSign makepri.exe (since 20.33.1) #3654

mirka opened this issue Jan 31, 2019 · 2 comments
Labels

Comments

@mirka
Copy link

mirka commented Jan 31, 2019

  • Version: 20.33.1 thru 20.38.5 (It was working up to 20.32.0)
  • Target: AppX

Starting in version 20.33.1, our appx build fails with this error:

  • building        target=AppX arch=ia32 file=release\Simplenote-win-1.3.4-ia32.appx
Error: Exit code: 2148008452. Command failed: C:\Users\appveyor\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.4.0\windows-10\ia32\makepri.exe new /Overwrite /Manifest C:\projects\simplenote-electron\release\__appx-ia32\AppxManifest.xml /ProjectRoot C:\projects\simplenote-electron\release\__appx-ia32\appx /ConfigXml C:\projects\simplenote-electron\node_modules\app-builder-lib\templates\appx\priconfig.xml /OutputFile C:\projects\simplenote-electron\release\__appx-ia32\resources.pri

All of our other targets (dmg, nsis, linux, and also unsigned appx) are unaffected.

Do you have any idea what may be causing this? I'm wondering if it's related to this commit → 76fdd42

@stale
Copy link

stale bot commented Jul 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@belcherj
Copy link

belcherj commented Jan 3, 2020

I think that error code means that the manifest is invalid: "The Appx package's manifest is invalid"

If this is to be trusted: https://www.hresult.info/FACILITY_WINDOWS/0x80080204

This would indicated the error is that the manifest is not valid XML "APPX_E_INVALID_MANIFEST": https://docs.microsoft.com/en-us/windows/win32/api/appxpackaging/nf-appxpackaging-iappxfactory-createmanifestreader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants