Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder 20.29.0+ bundles fail to run on macOS Catalina #4179

Closed
poiru opened this issue Aug 24, 2019 · 8 comments
Closed

electron-builder 20.29.0+ bundles fail to run on macOS Catalina #4179

poiru opened this issue Aug 24, 2019 · 8 comments
Labels

Comments

@poiru
Copy link

poiru commented Aug 24, 2019

There seems to be a regression between electron-builder 20.28.4 and 20.29.0 that makes the app not run on macOS Catalina with an error like "The application Foo.app can't be opened":

catalina-error

Note that this is not a notarization error, it's something different.

Repro steps:

  • Package app using electron-webpack-quick-start@master on a Mojave machine, upload .zip to the internet, download on Catalina and attempt to run the app. The app fails to run with the message above.

  • Package app using electron-webpack-quick-start@09ae10e82e728047aed5e7341c4a555398fee33d (uses electron-builder 20.28.1), repeat steps above, and confirm that it works fine on Catalina although you might get a different "can't check for malicious software" app notarization error

To make our app compatible with macOS Catalina, we downgraded to electron-builder@20.28.4, build into a directory using --dir, manually run electron-osx-sign with --entitlements="entitlements.plist" --entitlements-inherit="entitlements.plist" --hardened-runtime=true, manually run electron-notarize, and manually create a .zip.

@timfish
Copy link
Contributor

timfish commented Sep 2, 2019

20.28.4 and 20.29.0 are so old and there have been may recent fixes to improve notarisation support.

Have you tried the latest 21.2.0?

@mcous
Copy link

mcous commented Sep 5, 2019

I am also encountering this issue on electron-builder@21.2.0. This appears to be the same issue as #4108

This occurs for me regardless of if I use an afterSign script to notarize the app. My mac configuration is:

mac:
  target:
    - dmg
    - zip
  category: public.app-category.productivity
  type: distribution

Versions:

  • macOS - 10.15 Beta (19A546d)
  • electron - 3.1.13
  • electron-builder - 21.2.0

@timfish
Copy link
Contributor

timfish commented Sep 5, 2019

I had assumed that Electron v4.x was a requirement for notarisation but not really sure where I got that from.

I had the same crash at startup when using anything but the default entitlements but now everything works even with custom entitlements and can't reproduce the previous issues so it's a weird one...

@mcous
Copy link

mcous commented Sep 5, 2019

I had assumed that Electron v4.x was a requirement for notarisation but not really sure where I got that from.

Oh man, if you do find any concrete information on that, would you please ping me? I'd like to keep us on the 3.x line for macOS 10.9 support. Then again, Electron v3 is EoL'd, so maybe I should just do the responsible thing and update.

In terms of repro, I running into some really weird stuff:

  • Build machine: macOS 10.14.6
  • Test machine: VM running macOS 10.15 Beta (19A546d)

Testing with an unnotarized app I have no issues with the ZIP file on my 10.14 machine. On the 10.15 machine, where I obtain the ZIP file by downloading it from a server:

  • Unzip the archive by double-clicking (Archive Utility)
    • "The application can't be opened"
    • Open inspection, the executable in Contents/MacOS is lacking executable permission
    • chmod +x, try to open, '"App Name" is damaged and can't be opened. You should move it to the Trash'
  • Unzip the archive with a different GUI app (Keka)
    • Application hits Gatekeeper (expected behavior), Gatekeeper complains
  • Unzip the archive with unzip
    • Application launches (???)

With a notarized build on 10.15

  • Unzip the archive by double-clicking (Achive Utility)
    • "The application can't be opened"
    • Same behavior as above
  • Unzip the archive with a different GUI app (Keka)
    • Application hits Gatekeeper
    • '"App Name" is an app created by Keka. Are you sure you want to open it? Keka created this file on an unknown date.'
    • Click "Open", application launches
  • Unzip the archive with unzip
    • '"App Name" is an app downloaded from the Internet. Are you sure you want to open it?'
    • This feels "correct" to me

So I guess that leaves us with the following list of options?

  • Bug in the 10.15 Beta version of Archive Utility
  • Problem with the ZIP output of electron-builder that causes certain unzippers to do weird things with permissions
  • Something else entirely

The good news is that this doesn't appear to affect auto-update on mac for me, so I think I can proceed by simply distributing the DMG and I guess just crossing my fingers?

@gschier
Copy link

gschier commented Oct 10, 2019

I noticed the same thing as @mcous. I tested on Mojave and extracting/running the notarized zip works fine so it seems like an issue with Archive Utility on Catalina not correctly extracting notarized apps.

@poiru
Copy link
Author

poiru commented Oct 11, 2019

Duplicate issue and potential workaround: #4299 (comment)

@semireg
Copy link

semireg commented Oct 23, 2019

See comment #4299 (comment)

@stale
Copy link

stale bot commented Dec 22, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Dec 22, 2019
@stale stale bot closed this as completed Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants