Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot rename file using configuration build.files #4522

Closed
KoltesDigital opened this issue Dec 11, 2019 · 13 comments
Closed

Cannot rename file using configuration build.files #4522

KoltesDigital opened this issue Dec 11, 2019 · 13 comments
Labels

Comments

@KoltesDigital
Copy link

  • Version: 21.2.0
  • Target: NA

The doc states that app contents can be renamed using from and to (#1119). However it doesn't work:

  1. Setting from to an existing file path, and to to the expected file path, the expected file does not exist in the asar. It seems from is still considered as a directory path, since the FileMatcher contains **/* in patterns. Maybe glob doesn't return anything now, while when you implemented this feature it returned the original path?
  2. Not setting from, but instead setting filter to ["<file path>"], actually creates a directory at the expected file path, containing a hierarchy of dirs and finally a unique file, with the original name.
  3. Setting from to the file's directory, and setting the filename in filter, does the same as point 2 expect the file is directly in the directory.

There's no explanations in the doc, so I have no other ideas. Can you please check the feature is working as intended, and if so, give some more details?

@stale
Copy link

stale bot commented Feb 9, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Feb 9, 2020
@KoltesDigital
Copy link
Author

Of course it is still relevant, you haven't even replied.

@stale stale bot removed the backlog label Feb 9, 2020
@stale
Copy link

stale bot commented Apr 9, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 9, 2020
@KoltesDigital
Copy link
Author

Yes it is.

@stale stale bot removed the backlog label Apr 13, 2020
@stale
Copy link

stale bot commented Jun 12, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Jun 12, 2020
@KoltesDigital
Copy link
Author

...

@stale stale bot removed the backlog label Jun 12, 2020
@stale
Copy link

stale bot commented Aug 11, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Aug 11, 2020
@KoltesDigital
Copy link
Author

...

@stale stale bot removed the backlog label Aug 18, 2020
@conrallendale
Copy link

from is really treated like a dir. walk in fs perform a readdir in it, returning no results. Then, in platformPackager.js method copyAppFiles, files is filtred for empty: return result.filter(it => it.files.length > 0);

@conrallendale
Copy link

Workaround is to disable asar (asar: false), then use extraResources to copy files to app folder, like:

extraResources:
  - from: .env.client.production
    to: app/.env.client

@stale
Copy link

stale bot commented Nov 24, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Nov 24, 2020
@KoltesDigital
Copy link
Author

stalebot: ...

@conrallendale thanks for digging and for the workaround. Mine is to simply copy files before running electron build.

@stale stale bot removed the backlog label Nov 30, 2020
@stale
Copy link

stale bot commented Feb 2, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Feb 2, 2021
@stale stale bot closed this as completed Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants