Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing/notarization status #4934

Closed
mihaiav opened this issue May 6, 2020 · 3 comments
Closed

Signing/notarization status #4934

mihaiav opened this issue May 6, 2020 · 3 comments
Labels

Comments

@mihaiav
Copy link

mihaiav commented May 6, 2020

  • Version:

22.6.0

  • Electron Version:
    8.2.5

  • Electron Type (current, beta, nightly):

  • Target:
    Mac

Application is not notarized. Is this a known issue? If so could we update the signing docs to make it clear that the current signing is not working on the macOS 10.14.5 or higher?

@b-zurg
Copy link
Contributor

b-zurg commented May 6, 2020

There's a few articles floating around about how to notarize the app and a pinned issue:

#3870

I think the dust is still settling on this. I haven't gotten notarization totally working either but that's not because of electron-builder but a separate issue with a native dependency not supporting hardened runtime.

I would recommend following this article - https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/

It's mentioned in the docs briefly but I agree the documentation could use a revamp with all of the changes that have happened.

@jrowny
Copy link

jrowny commented May 7, 2020

I believe this #4656 is the actual issue. This has been fixed in electron-osx-sign, but it seems like that code was forked into electron-builder so electron-builder didn't get the fix.

I think for now the only thing we can do is manually sign.

@stale
Copy link

stale bot commented Jul 6, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants