feat(snap): add Snap title option
#5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneys
changed the title
title optiontitle option
mmaietta
pushed a commit
to mmaietta/electron-builder
that referenced
this pull request
Dec 2, 2020
mmaietta
pushed a commit
to mmaietta/electron-builder
that referenced
this pull request
Dec 2, 2020
- 12:98 error Don't use `Object` as a type. The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`. - 37:9 error 'label' is never reassigned. Use 'const' instead prefer-const Fixing buildResources directory "default" to be a fully defined path as a fallback resource Updating snapTest snapshots to include new title entry introduced in PR electron-userland#5350 Switching to japanese for dmg-license tests since russian does not have a default label
mmaietta
pushed a commit
to mmaietta/electron-builder
that referenced
this pull request
Dec 2, 2020
- 12:98 error Don't use `Object` as a type. The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`. - 37:9 error 'label' is never reassigned. Use 'const' instead prefer-const Fixing buildResources directory "default" to be a fully defined path as a fallback resource Updating snapTest snapshots to include new title entry introduced in PR electron-userland#5350 Switching to japanese for dmg-license tests since russian does not have a default label
develar
pushed a commit
that referenced
this pull request
Dec 9, 2020
* Fixed compiler errors with ``` /Users/travis/build/electron-userland/electron-builder/packages/dmg-builder/src/dmgLicense.ts 12:98 error Don't use `Object` as a type. The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`. - If you want a type meaning "any object", you probably want `Record<string, unknown>` instead. - If you want a type meaning "any value", you probably want `unknown` instead @typescript-eslint/ban-types 37:9 error 'label' is never reassigned. Use 'const' instead prefer-const ``` * Fixed compiler errors within dmgLicense.ts - 12:98 error Don't use `Object` as a type. The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`. - 37:9 error 'label' is never reassigned. Use 'const' instead prefer-const Fixing buildResources directory "default" to be a fully defined path as a fallback resource Updating snapTest snapshots to include new title entry introduced in PR #5350 Switching to japanese for dmg-license tests since russian does not have a default label * Bug fix: directories.buildResources must be used instead of buildResourcesDir (output dir) Bug fix: fallbackSources require a path to exist first Optimized logic using shorthand filters for undefined/null elements. * Updating license test files to conform to dmg license spec: https://github.com/argv-minus-one/dmg-license/blob/master/docs/License%20Specifications.md#license-specifications Bug fix: directories.buildResources (input dir) must be used instead of buildResourcesDir (output dir) Bug fix: fallbackSources require a path to exist, filter first Optimized logic using shorthand filters for undefined/null elements. * Test fix: license file paths are dynamic and must be scrubbed for test snapshots Co-authored-by: Mike Maietta <michaelmaietta@upwork.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the
titleoption for theSnapformat.Implementation
The option defaults to
productName.Background
The
titleattribute (see Snap format) describes:"An optional title for the snap, may contain uppercase letters and spaces"
Documentation
A pull request containing the supplemental documentation was created separately:
docs(snap): add documentation for Snap
titleoption (for #5350)