Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create a universal build #5547

Closed
XRenSiu opened this issue Jan 15, 2021 · 2 comments · Fixed by #5550
Closed

Can't create a universal build #5547

XRenSiu opened this issue Jan 15, 2021 · 2 comments · Fixed by #5550

Comments

@XRenSiu
Copy link

XRenSiu commented Jan 15, 2021

  • Version: 22.10.4
  • Electron Version: 11.1.1
  • Electron Type (current, beta, nightly):current
  • Target: mac universal

Error: Expected all non-binary files to have identical SHAs when creating a universal build but "Contents/Info.plist" did not

@mmaietta
Copy link
Collaborator

@quanglam2807 is this similar to what you were experiencing? #5481 (comment)
What did you mean by unify the app.asar process?

So in this case, we can opt to remove AsarIntegrity from Info.plist. Or we can unify the app.asar process for universal build.

Another thought is to disable for universal builds: asarOptions == null || arch == Arch.universal, but I'm not familiar with this usage of electron-builder

asarIntegrity: asarOptions == null ? null : await computeData(resourcesPath, asarOptions.externalAllowed ? {externalAllowed: true} : null),

@quanglam2807
Copy link
Contributor

@mmaietta Yes, if we disable asarIntegrity, this would be fixed. This is the patch I'm currently using: https://github.com/webcatalog/translatium/blob/287d5221656dbe7a640a43052d051ea0c97eb66c/patches/app-builder-lib%2B22.10.4.patch
I'm not sure what it is used for but I'm disabling it in production and nothing breaks.

What did you mean by unify the app.asar process?
I was thinking we could use the same app.asar file for all architectures, so the archIntegrity field is the same for all Info.plist. But now as I think about it, it's not a good idea as binaries in each app.asar would be compiled explicitly for each arch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants