-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol (scheme) for windows #623
Comments
Squirrel.Windows: do it on some squirrel event NSIS: will be implemented soon, workaround: #583 |
Very interested in this too :) |
I followed the instructions in #583 but it isn't working for me. I have installer.nsh in the build/ directory, and I know it is reading it because I had a typo in a variable name and the build failed. When I fixed the typo, the build succeeded. Here is my installer.nsh:
(replace But when I run the installer, I'm not seeing any of these registry keys get created. Is there another step I'm missing? Is there any way for me to see the actual configuration file being passed to nsis, so I can diagnose what's wrong? I did have this working in a previous version of electron-builder (back when you used to have to run packager manually), by passing the entire NSIS template file. But I'd like to avoid doing that if I can, for obvious reasons. |
I figured out my problem. I didn't set the installer to |
Docs is not yet updated because I am not sure. If anyone can confirm and fix docs — please PR. |
Moved to backlog to keep issue list clear. |
hey, first thx for your comments, can you tell me if I have to replace When you et |
Those two identifiers are already defined. And yes, per machine goes into build.nsis object. |
@joshua-smith : I set perMachine : true and nsh script still not writing register key after installation process !! installer.nsh
package.json`{
} |
@digitalberry-ahmed , have you figured it out? Moving from Electron 2 to 3, the custom protocol registration stopped working for me too, regardless of |
yeah, i got the same problem.There is not much info about how to get Protocol (scheme) work for windows. |
@woxixiulayin, for now I've solved it using this package: |
@noseratio thanks for your reply.I just want to register protocol during app installing in windows. |
@develar this is quite easy to implement via the NSIS script. I'm using the following macro to make it work:
And then I just call it for each protocol. It could be done here for the protocols defined in the Build configuration. |
@hacdias you have a couple of differences to what was suggested above. First you have |
@dannyharding10
The |
@hacdias good to know, thank you! I also noticed yours includes |
I have Yes, it's still working here. |
I'm trying to build my application for OSX and for Windows. Right now my package.json looks like below:
So everything working for OSX and I can open application using
myapp://
scheme. How can I make the same for Windows?The text was updated successfully, but these errors were encountered: