Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatting of Code in the MacOS PKG docs #7142

Merged
merged 3 commits into from Sep 23, 2022

Conversation

hrueger
Copy link
Contributor

@hrueger hrueger commented Sep 16, 2022

Before:
grafik

After:
grafik

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2022

🦋 Changeset detected

Latest commit: a04657c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit a04657c
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/632dece86779c50009f05b1a
😎 Deploy Preview https://deploy-preview-7142--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta
Copy link
Collaborator

Thanks for contributing!
Can you please regenerate the docs and schema json file via pnpm generate-all?

@mmaietta mmaietta changed the title Fix formatting of Code in the MacOS PKG docs fix: formatting of Code in the MacOS PKG docs Sep 16, 2022
@hrueger
Copy link
Contributor Author

hrueger commented Sep 17, 2022

Sure, am I right that I need to run pnpm i before that? Unfortunately, this does not work, I only get this:

Scope: all 14 workspace projects
 WARN  There are cyclic workspace dependencies: A:\_Source\electron-builder\packages\app-builder-lib, A:\_Source\electron-builder\packages\dmg-builder; A:\_Source\electron-builder\packages\app-builder-lib, A:\_Source\electron-builder\packages\dmg-builder, A:\_Source\electron-builder\packages\app-builder-lib, A:\_Source\electron-builder\packages\electron-builder-squirrel-windows      
Lockfile is up to date, resolution step is skipped
Packages: +1410
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++  
Packages are copied from the content-addressable store to the virtual store.
  Content-addressable store is at: A:\.pnpm-store\v3
  Virtual store is at:             node_modules/.pnpm
Downloading registry.npmjs.org/typescript/4.3.5: 10.6 MB/10.6 MB, done
Downloading registry.npmjs.org/typescript/4.2.4: 10.4 MB/10.4 MB, done
Downloading registry.npmjs.org/app-builder-bin/4.0.0: 45.1 MB/45.1 MB, done
Progress: resolved 1410, reused 0, downloaded 1383, added 1410, done
node_modules/.pnpm/esbuild@0.12.29/node_modules/esbuild: Running postinstall script, done in 2s
node_modules/.pnpm/puppeteer@2.1.1/node_modules/puppeteer: Running install script, done in 28.3s

dependencies:
+ dmg-license 1.0.11

devDependencies:
+ @babel/plugin-transform-modules-commonjs 7.15.4
+ @changesets/changelog-github 0.4.2
+ @changesets/cli 2.19.0
+ @milahu/patch-package-with-pnpm-support 6.4.8
+ @types/node 16.11.43
+ @typescript-eslint/eslint-plugin 4.33.0
+ @typescript-eslint/parser 4.33.0
+ catharsis 0.9.0
+ conventional-changelog-cli 2.1.1
+ dmd 6.0.0
+ eslint 7.30.0
+ eslint-config-prettier 8.3.0
+ eslint-plugin-prettier 3.4.0
+ fs-extra 10.0.0
+ globby 11.0.4
+ husky 7.0.4
+ jest-cli 27.0.6
+ jsdoc-to-markdown 7.0.1
+ lint-staged 11.1.2
+ markdown2html-pro 1.0.6
+ path-sort 0.1.0
+ prettier 2.3.2
+ replace-in-file 6.2.0
+ source-map-support 0.5.21
+ ts-jsdoc 3.2.2
+ typescript 4.3.5
+ typescript-json-schema 0.51.0
+ v8-compile-cache 2.3.0

. postinstall$ patch-package
│ node:internal/modules/cjs/loader:936
│   throw err;
│   ^
│ Error: Cannot find module './dist/index.js'
│ Require stack:
│ - A:\_Source\electron-builder\node_modules\.pnpm\github.com+milahu+patch-package@6b85a8bc1562d1482f30c1b65c9f4e91ba657d39\node_modules\@milahu\patch-package-with-pnpm-support\index.js        
│     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
│     at Function.Module._load (node:internal/modules/cjs/loader:778:27)
│     at Module.require (node:internal/modules/cjs/loader:1005:19)
│     at require (node:internal/modules/cjs/helpers:102:18)
│     at Object.<anonymous> (A:\_Source\electron-builder\node_modules\.pnpm\github.com+milahu+patch-package@6b85a8bc1562d1482f30c1b65c9f4e91ba657d39\node_modules\@milahu\patch-package-with-pn  
│     at Module._compile (node:internal/modules/cjs/loader:1101:14)
│     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
│     at Module.load (node:internal/modules/cjs/loader:981:32)
│     at Function.Module._load (node:internal/modules/cjs/loader:822:12)
│     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
│   code: 'MODULE_NOT_FOUND',
│   requireStack: [
│     'A:\\_Source\\electron-builder\\node_modules\\.pnpm\\github.com+milahu+patch-package@6b85a8bc1562d1482f30c1b65c9f4e91ba657d39\\node_modules\\@milahu\\patch-package-with-pnpm-support\\in  
│   ]
│ }
└─ Failed in 90ms
 ELIFECYCLE  Command failed with exit code 1.

Did I miss any docs on how to setup the dev environment correctly?

@mmaietta
Copy link
Collaborator

Hmmm, I feel like I recall a similar issue in the past.

Can you try installing yarn globally if not already? I'm wondering if that fork of patch-package has an external dependency.

Also, if not already, please try with node 14.

@hrueger
Copy link
Contributor Author

hrueger commented Sep 19, 2022

Yarn is installed globally. I did manage to run the command, though, using gitpod, as I didn't want to change my node version.

@mmaietta mmaietta merged commit 9338097 into electron-userland:master Sep 23, 2022
@github-actions github-actions bot mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants