Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arm64): RPM architecture name #7466

Merged
merged 2 commits into from Mar 16, 2023
Merged

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Mar 7, 2023

It feels like just having aarch64 in the filename is not sufficient.

[root@7b42929061f0 /]# uname -a
Linux 7b42929061f0 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

yum install https://github.com/MuhammedKalkan/OpenLens/releases/download/v6.4.4/OpenLens-6.4.4.aarch64.rpm
Error:
 Problem: conflicting requests
  - package open-lens-6.4.4-1.arm64 does not have a compatible architecture
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

There is also an fix available on fpm, but this requires fpm 1.13.0 or higher

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: d0f2265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
builder-util Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-publish Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit d0f2265
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6412937bf572580008af2a72
😎 Deploy Preview https://deploy-preview-7466--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta
Copy link
Collaborator

It feels like just having aarch64 in the filename is not sufficient.

Can you elaborate on this? This seems like a breaking change

@jkroepke
Copy link
Contributor Author

jkroepke commented Mar 10, 2023

Can you elaborate on this? This seems like a breaking change

I post a console output. You can reproduce it by trying it out. On RedHat systems, the arch called aarch64.

In case you avoid this breaking change in the code, bump the embedded fpm version which does the same. See upstream jordansissel/fpm@cc0a4e7#diff-a93d61ffd6fa3f2b9405387c603649469db300e9c5145c62020e47b44d71b16cR242-R243 .

Here is another example, where a users renamed the arch in the rpm to solve the issue: MuhammedKalkan/OpenLens#103 (comment)

@mmaietta
Copy link
Collaborator

Here is another example, where a users renamed the arch in the rpm to solve the issue

Sorry, can you elaborate? I'm not sure how the aarch64 name suffix is needed. Does the install require that suffix in order to identify arch?

@jkroepke
Copy link
Contributor Author

At this
Moment, the RPM is build with arm64 arch, but there is no arm64 arch on RPM based systems. On RPM based systems, the arch is called aarch64. The arch Information is part of the RPM metadata which is currently wrong.

Please explain precisely what is still missing?

@mmaietta mmaietta merged commit 1342f87 into electron-userland:master Mar 16, 2023
12 checks passed
@jkroepke jkroepke deleted the patch-1 branch March 16, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants