Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating SignOptions to leverage optionsForFile for entitlements #7491

Merged
merged 10 commits into from Mar 22, 2023

Conversation

mmaietta
Copy link
Collaborator

Adding additional typesafety and fixing large issue where entitlements don't seem to be applied properly due to major semver bump in electron/osx-sign

Fixes: #7471

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

🦋 Changeset detected

Latest commit: ad99990

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit ad99990
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/641b83a0a6a1e50008e472f5
😎 Deploy Preview https://deploy-preview-7491--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta merged commit c1deace into master Mar 22, 2023
12 checks passed
@mmaietta mmaietta deleted the fix/osx-sign-entitlements branch March 22, 2023 23:54
@github-actions github-actions bot mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Not Available for Testing" After upgrading from 23.6.0 to 24.0.0
1 participant