Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying recommended dependencies for deb target #7558

Merged
merged 3 commits into from Apr 26, 2023

Conversation

t3chguy
Copy link
Contributor

@t3chguy t3chguy commented Apr 24, 2023

Closes develar/app-builder#87

deb.fpm: ['--deb-recommend=blah'] is insufficient as https://github.com/develar/app-builder always forces a libappindicator3-1 into the recommendeds.

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2023

🦋 Changeset detected

Latest commit: ba228bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit ba228bb
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6447fac83059080008bab640
😎 Deploy Preview https://deploy-preview-7558--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@t3chguy t3chguy marked this pull request as ready for review April 24, 2023 18:24
@t3chguy t3chguy changed the title Allow specifying recommended dependencies for deb target feat: allow specifying recommended dependencies for deb target Apr 24, 2023
@t3chguy t3chguy requested a review from mmaietta April 25, 2023 16:07
@mmaietta mmaietta merged commit 54c8537 into electron-userland:master Apr 26, 2023
13 checks passed
@t3chguy
Copy link
Contributor Author

t3chguy commented Apr 26, 2023

@mmaietta thanks for landing the PRs

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop libappindicator3-1 deb-recommends
2 participants