Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow building MAS and dmg targets with different appId #7603

Merged
merged 3 commits into from Jun 14, 2023

Conversation

GabrielNSD
Copy link
Contributor

This changes allows packaging different macOS targets with different CFBundleIndetifiers.
It makes the createMacApp to look for a CFBundleIdentifier in mas config, if the app is MAS.

Solving the issue related here: #7570

Current implementation ignores any appId specified in mas, directly using appInfo.macBundleIdentifier when writing Plist file.

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: 89aaf83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 89aaf83
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6489ef6e25554b000823e4da
😎 Deploy Preview https://deploy-preview-7603--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@GabrielNSD GabrielNSD changed the title Allow building MAS and dmg targets with different appId fix: Allow building MAS and dmg targets with different appId Jun 7, 2023
@mmaietta mmaietta merged commit f464e3e into electron-userland:master Jun 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants