Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compat with newest @types/node #7806

Merged
merged 3 commits into from Oct 26, 2023

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Oct 1, 2023

due to DefinitelyTyped/DefinitelyTyped#66783 we got a downstream type error on httpExecutor's RequestHeaders
fixed by using OutgoingHttpHeader from node
bumped repo's @types/node to verify fix

due to DefinitelyTyped/DefinitelyTyped#66783 we got a downstream type error on httpExecutor's RequestHeaders
fixed by using OutgoingHttpHeader from node
bumped repo's @types/node to verify fix
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2023

🦋 Changeset detected

Latest commit: 98829b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
builder-util-runtime Patch
builder-util Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder Patch
electron-publish Patch
electron-updater Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 98829b1
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6539221bf0070a0008871eb4
😎 Deploy Preview https://deploy-preview-7806--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

I think you'll also need to update this line of code here:

Then please run pnpm generate-all in case additional locations in the docs are needed

@ScubaDrew
Copy link

Running into this. Typlically how long is it until we see something like this release? Thank you!

@mmaietta
Copy link
Collaborator

Resolve this comment #7806 (comment)

And I can release a version via our automation as soon as this PR is merged.

@mmaietta
Copy link
Collaborator

@AviVahl would you mind following up on this PR with the requested change?

If not able to, let me know and I can pick up the work in a separate PR.

@AviVahl
Copy link
Contributor Author

AviVahl commented Oct 24, 2023

I'm not able to atm. Please do. I've also allowed maintainers to commit to my fork/branch if you want to continue working on this PR directly.

@mmaietta mmaietta merged commit db424e8 into electron-userland:master Oct 26, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants