Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support executableName in main config #7828

Merged
merged 1 commit into from Oct 18, 2023
Merged

fix: support executableName in main config #7828

merged 1 commit into from Oct 18, 2023

Conversation

BrandonXLF
Copy link
Contributor

@BrandonXLF BrandonXLF commented Oct 15, 2023

Should be supported according to the documentation electron.build/configuration/configuration#overridable-per-platform-options

Fixes #7826

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

🦋 Changeset detected

Latest commit: 6b1adc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 6b1adc6
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/652ba6829892c800088a5b7e
😎 Deploy Preview https://deploy-preview-7828--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 7c7db83 into electron-userland:master Oct 18, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow executableName to be set in the top-level config
2 participants