Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electronuserland/builder:18 has node v18.15.0 but I need 18.16.0 #7848

Closed
ScubaDrew opened this issue Oct 26, 2023 · 7 comments
Closed

electronuserland/builder:18 has node v18.15.0 but I need 18.16.0 #7848

ScubaDrew opened this issue Oct 26, 2023 · 7 comments

Comments

@ScubaDrew
Copy link

ScubaDrew commented Oct 26, 2023

electronuserland/builder:18

  • Electron-Builder Version: 24.6.4
  • Node Version: 18.16.0
  • Electron Version: 26.4.2

How can I get node 18.16.0+ in electronuserland/builder:18 ?

@mmaietta
Copy link
Collaborator

mmaietta commented Nov 6, 2023

I can update the docker images to latest node18. Would 18.17.0 work for you or does it have to be 18.16.0?

@ScubaDrew
Copy link
Author

Hey @mmaietta ! Thank you for responding. I'd upgrade to whatever is best for the community, not just me :)

I'm surprised I'm the only one running into this. It seems like if we had electronuserland/builder:18.16.0 and other versions as tagged containers, that would serve the most folks the best.

Again, I am a single developer, and and an electron beginner - so maybe I'm doing something entirely wrong here. I'm very surprised to be the only one running into this.

@mmaietta
Copy link
Collaborator

mmaietta commented Nov 6, 2023

I've been debating on tagging images with the Node version for some time now. Previously it was always the month-day, but I'm not sure why.

@ScubaDrew
Copy link
Author

Yeah month-day -- can't think of a good reason for that except easier to implement a scheduled build?

@mmaietta
Copy link
Collaborator

@ScubaDrew
Copy link
Author

Thanks @mmaietta I'll give it a shot!

@mmaietta
Copy link
Collaborator

Scratch that. Forcing a redeploy, I think the ARG was overridden by a build script. Will be upgraded in #7882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants