Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win): use resultOutputPath to sign custom location for windows #7919

Merged
merged 2 commits into from Dec 4, 2023

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Dec 4, 2023

fix: pull resultOutputPath from CustomWindowsSignTaskConfiguration (fixes: #7910)

Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: 133cd09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 133cd09
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/656df938da784d00088c442c
😎 Deploy Preview https://deploy-preview-7919--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 4e930a7 into master Dec 4, 2023
14 checks passed
@mmaietta mmaietta deleted the fix/custom-windows-sign-location branch December 4, 2023 16:31
mmaietta added a commit that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Windows Signing does not work when signing to a different location
1 participant