fix(mac): use zip if name contains NFD characters #7929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7z normalizes filenames to the NFC form, so the signature verification fails if filenames contain characters that have different NFC and NFD form, e.g., diacritics and Hangul, and the unarchiver does not normalize them back to the NFD form. The Finder's
Archive Utility
does this, butditto
andunzip
don't, failing the auto update:Test repo: https://github.com/jebibot/electron-test-2