Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): use zip if name contains NFD characters #7929

Merged
merged 1 commit into from Dec 6, 2023

Conversation

jebibot
Copy link
Contributor

@jebibot jebibot commented Dec 6, 2023

7z normalizes filenames to the NFC form, so the signature verification fails if filenames contain characters that have different NFC and NFD form, e.g., diacritics and Hangul, and the unarchiver does not normalize them back to the NFD form. The Finder's Archive Utility does this, but ditto and unzip don't, failing the auto update:

Tést 테스트.app: a sealed resource is missing or invalid
file added: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper (Renderer).app
file added: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper.app
file added: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper (GPU).app
file added: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper (Plugin).app
file missing: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper.app
file missing: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper (Plugin).app
file missing: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper (GPU).app
file missing: /Users/y/Downloads/Tést 테스트.app/Contents/Frameworks/Tést 테스트 Helper (Renderer).app

Test repo: https://github.com/jebibot/electron-test-2

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: f2d834b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit f2d834b
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/657015bf1a9bff000856ba1e
😎 Deploy Preview https://deploy-preview-7929--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 0f43989 into electron-userland:master Dec 6, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants