Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nsis): add option to disable differential download #7950

Merged

Conversation

bronsonmock
Copy link
Contributor

add new option to skip differential download attempt and default to full download

Closes #4682

add new option to skip differential download attempt and default to full download

Closes electron-userland#4682
Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 40d151b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 40d151b
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6596d86d9451e300090e8876
😎 Deploy Preview https://deploy-preview-7950--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bronsonmock
Copy link
Contributor Author

If approved, could a maintainer please assist in updating the documentation?

I have been unable to resolve an environment issue that prevents me from generating the jsdoc for app-builder-lib and electron-updater:

app-builder-lib
> @electron-builder/monorepo@ jsdoc C:\Projects\Github\electron-builder
> ts2jsdoc packages/app-builder-lib

exception evaluating "{ ...this.packager.platformSpecificBuildOptions, ...(this.packager.config as any)[this.name] }" for property options
exception evaluating "{
    ...this.packager.platformSpecificBuildOptions,
    ...(this.packager.config as any)[this.name],
  }" for property options
exception evaluating "{ ...this.packager.platformSpecificBuildOptions, ...(this.packager.config as any)[this.name] }" for property options
exception evaluating "{ ...this.packager.platformSpecificBuildOptions, ...(this.packager.config as any)[this.name] }" for property options
exception evaluating "{
    allowAnywhere: true,
    allowCurrentUserHome: true,
    allowRootDirectory: true,
    ...this.packager.config.pkg,
  }" for property options
Generating JSDoc to C:\Projects\Github\electron-builder\scripts\jsdoc\out\builder-lib
Error: ENOENT: no such file or directory, open 'C:\Projects\Github\electron-builder\scripts\jsdoc\out\builder-lib\app-builder-lib-out-asar\asar.js'
    at processImmediate (node:internal/timers:471:21)
electron-updater
> @electron-builder/monorepo@ jsdoc C:\Projects\Github\electron-builder
> ts2jsdoc packages/electron-updater

Generating JSDoc to C:\Projects\Github\electron-builder\scripts\jsdoc\out\updater
Error: ENOENT: no such file or directory, open 'C:\Projects\Github\electron-builder\scripts\jsdoc\out\updater\electron-updater-out-providers\Provider.js'
    at processImmediate (node:internal/timers:471:21)

@mmaietta
Copy link
Collaborator

Thanks for your contribution! Couple notes:

  • You'll need to regenerate the docs probably for this change via pnpm generate-all
  • Also wanted to check, how did you test this? :)

@bronsonmock
Copy link
Contributor Author

Thanks for your contribution! Couple notes:

  • You'll need to regenerate the docs probably for this change via pnpm generate-all
  • Also wanted to check, how did you test this? :)

@mmaietta, thanks for the quick reply:

  • Would you be willing to help regenerate them? I have been having issues on my end when trying to update the docs (please see my earlier comment for more details).

  • I did some functional testing. I used yalc to link the compiled packages to my project and then performed several updates with the new option as both true and false. Observed that when the option is set to true, no statements corresponding to the differential update are logged to the console (block map checking, block download range, etc.).

@mmaietta mmaietta merged commit 03c9451 into electron-userland:master Jan 5, 2024
10 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can I disable differential download?
3 participants