fix: notarization with an apple API key #7951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a29afb The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bcomnes
force-pushed
the
fix-api-notarizing
branch
from
4b78321
to
bde2024
Compare
bcomnes
changed the title
Notarization wasn't actually running when the API key is set and notarize was set to true. The notarize tool library throws when a API key is provided and teamId is set, so you have to set notarize to true, but when you do currently, the step never runs. build
bcomnes
force-pushed
the
fix-api-notarizing
branch
from
bde2024
to
5ba029f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notarization wasn't actually running when the API key is set and notarize was set to true. The notarize tool library throws when a API key is provided and teamId is set, so you have to set notarize to true, but when you do currently, the step never runs.