Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: product file name is too long causing the find process exe failed #7955

Merged
merged 2 commits into from Jan 4, 2024

Conversation

bayun2
Copy link
Contributor

@bayun2 bayun2 commented Dec 21, 2023

On Windows 11, when the length of APP_EXECUTABLE_FILENAME exceeds 25 characters, the image name found through the tasklist command will be omitted, causing subsequent finde.exe to fail to find the specified process.

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: 2231425

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 2231425
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6596ce5cd00a1e0008a47512
😎 Deploy Preview https://deploy-preview-7955--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 88e61bc into electron-userland:master Jan 4, 2024
10 of 12 checks passed
@mmaietta
Copy link
Collaborator

mmaietta commented Jan 4, 2024

Failing tests are unrelated to this PR. Will be investigated separately to unblock release pipeline

Merging PR. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants