Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nsis): add NsisOption to specify selectPerMachineByDefault #7967

Conversation

jmeinke
Copy link
Contributor

@jmeinke jmeinke commented Jan 5, 2024

Add the possibility to create an assisted NSIS installer and select per Machine as default option for installation.
We need this for our installer.

Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: 92fbee9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 92fbee9
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/659842a16f36db000879a89b
😎 Deploy Preview https://deploy-preview-7967--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmeinke
Copy link
Contributor Author

jmeinke commented Jan 5, 2024

@mmaietta I too have had problems setting up the tools needed to re-create the docs. I therefore could need your help here. Thank you!

@mmaietta mmaietta merged commit 28e5b5d into electron-userland:master Jan 9, 2024
10 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants