Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notarize: true has no effect with apple API key #8040

Closed
dancarasco opened this issue Feb 8, 2024 · 3 comments · Fixed by #8065
Closed

notarize: true has no effect with apple API key #8040

dancarasco opened this issue Feb 8, 2024 · 3 comments · Fixed by #8065

Comments

@dancarasco
Copy link

dancarasco commented Feb 8, 2024

  • Electron-Builder Version: 24.9.1
  • Node Version: 20.11.0
  • Electron Version: 28.2.2
  • Electron Type (current, beta, nightly): current
  • Target: mac - dmg/universal, zip/universal

When setting the following env variables:

Screenshot 2024-02-08 at 01 02 47

And setting notarize to true:

Screenshot 2024-02-08 at 00 49 17

Notarizing silently fails in electron-builder:

Screenshot 2024-02-08 at 00 53 44

I would expect to see one of the following messages

skipped macOS notarization - notarize options were not provided
or
Env vars APPLE_API_KEY, APPLE_API_KEY_ID and APPLE_API_ISSUER need to be set
or
"notarization successful"

None appear.

@mmaietta
Copy link
Collaborator

mmaietta commented Feb 9, 2024

Can you please try without setting notarize: true, electron-builder should automatically detect based on the env vars being set. Would appreciate if you also tried this with next version v24.12.0

@dancarasco
Copy link
Author

Can you please try without setting notarize: true, electron-builder should automatically detect based on the env vars being set. Would appreciate if you also tried this with next version v24.12.0

Removed notarize: true from package.json and received the following warning:

Screenshot 2024-02-13 at 20 43 57

Same behaviour on both v24.9.1 and v24.12.0

Can confirm the App Store Connect env vars are present in the environment:

echo ${APPLE_API_KEY} returns the full path to the .p8 file which contains a valid PRIVATE KEY.
echo ${APPLE_API_KEY_ID} returns the the 10 character key ID.
echo ${APPLE_API_ISSUER} returns the issuer UUID.

MacBook Pro / M2 Max / Sonoma 14.3.1

@mmaietta
Copy link
Collaborator

Will take a look at it this week. (Currently swamped with work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants