This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
feat(TypeScriptCompiler): utilize ts compiler api directly instead of 3rd party module #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing PR as changes are checked in accordingly. |
|
So confused, why didn't GitHub mark this as merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced change to
TypeScriptCompilerimplementation, no longer rely on 3rd party compiler wrapper (typescript-simple) instead directly consume TypeScript compiler api.This change is BREAKING change for several reasons,
peerDependencies, have minimum requirement of>=1.6to support latest breaking compiler api surface.electron-compilers no longer automatically mutate some of compiler options based on context, strictly consume user configuration object as-is. Means, if user accidentally unspecified / incorrectly specified some of configs (like not settingreactfor tsx), user will experience compilation failure sinceTypeScriptCompilerimpl no logner touches it.